forked from Azure/azure-sdk-for-java
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoPR compute/resource-manager/v2017_03_30] [Compute] Add missing $expand parameter to AvSet list by subscription API #304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a flag to the pipeline which controls whether it is a track 1 or track 2 build.
* Formatting changes in EventHubAsyncProducer. * Adding EventHubClient, EventHubConsumer, and EventHubProducer. * Exposing EventHubClient creation in EventHubClientBuilder. * EventHubClient, Consumer and Producer implements Closeable. * Fixing sample by removing event hub instance from namespace connection string. * Remove unneeded sample in EventHubClientBuilder. * Add EventHubClient to builder annotation. * Update EventHubClientBuilder samples. Remove unneeded ones. * Update samples in EventHubClientBuilder. * Fixing links to EventHubAsyncProducer samples. * Adding EventHubProducer code samples. * Update from Iterable to IterableResponse. * Make test contents package-private. * Adding tests for EventHubProducer. * Simplifying creation of EventHubAsyncProducer * Select correct retryDuration when constructing EventHubProducer. * Adding EventHubProducer tests. * Rename EventHubClientIntegrationTest -> EventHubAsyncClientIntegrationTests * Add integration tests for EventHubClient. * Make EventHubConsumer methods public
* Split the eventhubs client and data pipelines. * Removed redundant modules section. * Specified artifacts for data pipeline.
* Seeing if we can speed up spotbugs by not forking the JVM for each module
* remove java code isImple check but move to suppression and add only check for public class for external Dependency check * fixes * Update eng/code-quality-reports/src/main/resources/checkstyle/checkstyle-suppressions.xml suggest changes on comments Co-Authored-By: Connie Yau <[email protected]>
* Move Storage to official swagger files There are no (meaningful) code changes except the attribute in BlobHierarchyListSegment that I can't trace to the swagger * Upgrade blobs swagger to 2019-02-02 Note that additional work will have to be done to patch our higher level code to pass new parameters to existing APIs * Fixes to Swagger generation and updating to use new protocol layer * Fixed appendBlock content-type, added SpotBug exclusions for autogen code * Update README.md * Fixed incorrect exclude
* Migrate queue to spock test framework * Remove all Junit tests and dependencies
…literals usage (#4994) * Adding javaDoc formating rule * Adding fixes for javadoc formatting
* Add staging profile.
…ion mark, if so remove it (#5024)
* Created StorageException for Files and Queues, moved it into models for Blobs, made it a POJO * Using getX naming and cleaned up unit test imports * Fixed additional imports * Fixed import and ignored issue with enum serialization
* Smoke Test for Key Vault, Storage and Identity SDK * Create EventHubs.java * Update EventHubs.java * Update KeyVaultSecrets.java * Update App.java * Create CosmosDB files * CosmosDB finallized * Update EventHubs.java * Handling pre-cleaning the resource * Update App.java * Concurrency support * Update pom.xml * Review feedback * Reactive async in Cosmos * Use of Logger * Env Variables names changed * Create README.md * Use of logger in error message * Location changed to /eng/ * Create smoke-test.yml * Update smoke-test.yml * Update smoke-test.yml * Update smoke-test.yml * Update README.md * Website in pom.xml * MIT headers * static final named correctly * Avoiding import.* * nit: extra blank lines and logger
KV Track 1 OkHttp Bug fix.
…kstyle errors (#5032) * remove java code isImple check but move to suppression and add only check for public class for external Dependency check * refactor and fixes errors * add break
Good Logging Practice 1) ClientLogger in public API should all named 'logger', public API classes are those classes that are declared as public and that do not exist in an implementation package or subpackage. 2) ClientLogger should be non-static instance logger 3) Should not use any external logger class, only use ClientLogger. No slf4j, log4j, or other logging imports are allowed. 'System.out' and 'System.err' is not allowed as well. 4) All classes should use ClientLogger as logger only but except ClientLogger itself
* Remove Storage swagger files and reference azure-rest-api-specs Also includes a few changes to Queues that were there before switching swagger references (it may not have been regenerated in awhile?). * Removing last swagger file from repo, fixing tests to comply with new swagger generation * Added comment to get StorageErrorCode into the Swagger
Fluent Methods: All methods that return an instance of the class, and that have one parameter. The method name should not start with any word in the list of avoidStartWords. All methods should not be declared to throws any checked exceptions.
KV track 1 bug fix + pom updates
* use expected artifact names * remove -complete artifact from kv unified pipeline * remove -test from keyvault artifact specification (it does not output all currently expected artifacts)
…4712) Batch 2 Rule # 5 Service client methods: All methods that are in a class annotated with @ServiceClient, where the method has a @ServiceMethod annotation, should follow these rules: Methods names should follow a common vocabulary. Refer to Java spec for this naming pattern https://azure.github.io/azure-sdk/java_design.html. Method names imply certain rules around expected return type - these should all be validated. Methods should not have 'Async' added to their method name. Return types of async and sync clients should be as per guidelines: [this check will be ignored for now since I am still struggling on how to get the Reflection working in the code-quality-check] Return type for async collection should be of type ? extends PagedFlux Return type for async single value should be of type ? extends Mono Return type for sync collection should be of type ? extends PagedIterable Return type for sync single value should be of type ? extends Response Rule # 10 'withResponse' naming pattern: All methods annotated with @ServiceMethod that return a Response (or Mono) must have their method name end with 'withResponse'. If the service method does not return a Response or Mono, it must not end with 'withResponse'. Batch 3 Rule # 1 Context in all the right places: Context should be passed in as an argument to all public methods annotated with @ServiceMethod that return Response in sync clients. Only in the sync case: E.g. we want this: Public Response getFooWithResponse(int x, int y, Context c) In the async case, we should check to ensure we have no service methods that take Context! Rule # 6 Async client should have async = true property set in @ServiceClient annotation To validate this, if the class has @ServiceClient annotation and if the classname AsyncClient, verify that the async property of @ServiceClient annotation is set to true. Similarly, if the class has @ServiceClient annotation and if the classname is Client, verify that the async property of @ServiceClient annotation is set to false Change class Context to be final
…5154) * Adding java automatic module names to all track two client libraries. Removing a few unused dependencies. Enforcing a Maven baseline of 3.6.1 to tighten our tooling scope.
* This introduces a builder API for creating a NettyAsyncHttpClient instance. The next step would be to provide API in the client libraries to accept an HttpClient instance, so that people may customise their HTTP clients.
* Kusto: generate package v2019_05_15 * Fix build errors for kusto.
Added File and Queue SAS functionality for Storage
* Updating clients to use CREATE_NEW for downloadToFile methods * Unit tests and playback records * Fixing unit test and resource cleanup
* remove java code isImple check but move to suppression and add only check for public class for external Dependency check * change deque to LIFO queue
* Updating testing environment variables to match what is used * Turn on live tests for AppConfiguration and forcing tests to fail at end of module * Update tests.yml * Update tests.yml * Update globals.yml * Update archetype-sdk-tests.yml
* Creating a base type of PagedFlux, to allow other types to be created in cases where a subclass of PagedResponse is used.
5 tasks
openapi-sdkautomation
bot
force-pushed
the
sdkAutomation/compute/resource-manager/v2017_03_30@7078
branch
from
August 30, 2019 02:07
9204426
to
bf38460
Compare
Add missing $expand parameter to AvSet list by subscription API
openapi-sdkautomation
bot
force-pushed
the
sdkAutomation/compute/resource-manager/v2017_03_30@7078
branch
from
August 30, 2019 02:32
bf38460
to
30f4fd5
Compare
PhoenixHe-NV
deleted the
sdkAutomation/compute/resource-manager/v2017_03_30@7078
branch
October 21, 2019 09:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created to sync Azure/azure-rest-api-specs#7078